[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of m

From: Alberto Garcia
Subject: Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise
Date: Fri, 17 Feb 2017 11:06:31 +0100
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Fri 17 Feb 2017 09:06:04 AM CET, Pankaj Gupta wrote:
>  To maintain consistency at all the places use qemu_madvise wrapper
>  inplace of madvise call.

>      if (length > 0) {
> -        madvise((uint8_t *) t + offset, length, MADV_DONTNEED);
> +        qemu_madvise((uint8_t *) t + offset, length, QEMU_MADV_DONTNEED);

This was changed two months ago from qemu_madvise() to madvise(), is
there any reason why you want to revert that change? Those two calls are
not equivalent, please see commit 2f2c8d6b371cfc6689affb0b7e for an

> -    if (madvise(start, length, MADV_DONTNEED)) {
> +    if (qemu_madvise(start, length, QEMU_MADV_DONTNEED)) {
>          error_report("%s MADV_DONTNEED: %s", __func__, strerror(errno));

And this is the same case.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]