[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of m

From: Dr. David Alan Gilbert
Subject: Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise
Date: Fri, 17 Feb 2017 09:48:33 +0000
User-agent: Mutt/1.7.1 (2016-10-04)

* Kevin Wolf (address@hidden) wrote:
> Am 17.02.2017 um 09:06 hat Pankaj Gupta geschrieben:
> >  To maintain consistency at all the places use qemu_madvise wrapper
> >  inplace of madvise call.
> > 
> > Signed-off-by: Pankaj Gupta <address@hidden>
> Reviewed-by: Kevin Wolf <address@hidden>
> Juan/Dave, if one of you can give an Acked-by, I can take this through
> my tree.


That's wrong; qemu_madvise can end up going through posix_madvise and
using POSIX_MADV_DONTNEED, it has different semantics to the 
and we need the semantics of madvise - i.e. it's guaranteed to throw
away the pages, where as posix_madvise *may* throw away the pages if
the kernel feels like it.


> Kevin
Dr. David Alan Gilbert / address@hidden / Manchester, UK

reply via email to

[Prev in Thread] Current Thread [Next in Thread]