[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 0/8] bdrv_flush_io_queue removal, shared Linu
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v4 0/8] bdrv_flush_io_queue removal, shared LinuxAioState |
Date: |
Tue, 19 Apr 2016 17:09:58 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 19.04.2016 um 11:10 hat Stefan Hajnoczi geschrieben:
> On Thu, Apr 07, 2016 at 06:33:28PM +0200, Paolo Bonzini wrote:
> > Patch 1 comes from Kevin's series to do BlockBackend throttling.
> >
> > Patches 2-6 are from my bdrv_drain patches. They apply on top of Fam's
> > patch (which will be in 2.6) that introduces bdrv_co_drain. Patch 4
> > is new in this version, compared to v3.
> >
> > Patches 7-8 are new but based on Ming Lei's old submission.
> > I'm including them here because they apply on top of patches 2-6.
> >
> > Kevin Wolf (1):
> > block: Don't disable I/O throttling on sync requests
> >
> > Paolo Bonzini (7):
> > block: make bdrv_start_throttled_reqs return void
> > block: move restarting of throttled reqs to block/throttle-groups.c
> > block: extract bdrv_drain_poll/bdrv_co_yield_to_drain from
> > bdrv_drain/bdrv_co_drain
> > block: introduce bdrv_no_throttling_begin/end
> > block: plug whole tree at once, introduce bdrv_io_unplugged_begin/end
> > linux-aio: make it more type safe
> > linux-aio: share one LinuxAioState within an AioContext
> >
> > async.c | 23 +++++
> > block.c | 1 -
> > block/block-backend.c | 6 +-
> > block/io.c | 168
> > ++++++++++++++++++++++---------------
> > block/linux-aio.c | 60 ++++++-------
> > block/raw-posix.c | 133 ++++-------------------------
> > block/raw-win32.c | 2 +-
> > block/throttle-groups.c | 18 ++++
> > include/block/aio.h | 13 +++
> > include/block/block.h | 3 +-
> > include/block/block_int.h | 14 +++-
> > {block => include/block}/raw-aio.h | 15 ++--
> > include/block/throttle-groups.h | 1 +
> > 13 files changed, 216 insertions(+), 241 deletions(-)
> > rename {block => include/block}/raw-aio.h (80%)
>
> Looks good overall. I have reservations about the last patch, see my
> reply there.
>
> Acked-by: Stefan Hajnoczi <address@hidden>
Thanks, applied patches 1-7 to block-next.
Kevin
pgpTS43MSIKXa.pgp
Description: PGP signature
- [Qemu-block] [PATCH v4 3/8] block: move restarting of throttled reqs to block/throttle-groups.c, (continued)
- [Qemu-block] [PATCH v4 3/8] block: move restarting of throttled reqs to block/throttle-groups.c, Paolo Bonzini, 2016/04/07
- [Qemu-block] [PATCH v4 4/8] block: extract bdrv_drain_poll/bdrv_co_yield_to_drain from bdrv_drain/bdrv_co_drain, Paolo Bonzini, 2016/04/07
- [Qemu-block] [PATCH v4 1/8] block: Don't disable I/O throttling on sync requests, Paolo Bonzini, 2016/04/07
- [Qemu-block] [PATCH v4 2/8] block: make bdrv_start_throttled_reqs return void, Paolo Bonzini, 2016/04/07
- [Qemu-block] [PATCH v4 5/8] block: introduce bdrv_no_throttling_begin/end, Paolo Bonzini, 2016/04/07
- [Qemu-block] [PATCH v4 6/8] block: plug whole tree at once, introduce bdrv_io_unplugged_begin/end, Paolo Bonzini, 2016/04/07
- [Qemu-block] [PATCH v4 7/8] linux-aio: make it more type safe, Paolo Bonzini, 2016/04/07
- [Qemu-block] [PATCH v4 8/8] linux-aio: share one LinuxAioState within an AioContext, Paolo Bonzini, 2016/04/07
- Re: [Qemu-block] [PATCH v4 0/8] bdrv_flush_io_queue removal, shared LinuxAioState, Stefan Hajnoczi, 2016/04/19
- Re: [Qemu-block] [PATCH v4 0/8] bdrv_flush_io_queue removal, shared LinuxAioState,
Kevin Wolf <=