[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v4 2/8] block: make bdrv_start_throttled_reqs return
From: |
Paolo Bonzini |
Subject: |
[Qemu-block] [PATCH v4 2/8] block: make bdrv_start_throttled_reqs return void |
Date: |
Thu, 7 Apr 2016 18:33:30 +0200 |
The return value is unused and I am not sure why it would be useful.
Reviewed-by: Fam Zheng <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
block/io.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/block/io.c b/block/io.c
index a91d862..691baa6 100644
--- a/block/io.c
+++ b/block/io.c
@@ -71,10 +71,8 @@ void bdrv_set_io_limits(BlockDriverState *bs,
}
}
-/* this function drain all the throttled IOs */
-static bool bdrv_start_throttled_reqs(BlockDriverState *bs)
+static void bdrv_start_throttled_reqs(BlockDriverState *bs)
{
- bool drained = false;
bool enabled = bs->io_limits_enabled;
int i;
@@ -82,13 +80,11 @@ static bool bdrv_start_throttled_reqs(BlockDriverState *bs)
for (i = 0; i < 2; i++) {
while (qemu_co_enter_next(&bs->throttled_reqs[i])) {
- drained = true;
+ ;
}
}
bs->io_limits_enabled = enabled;
-
- return drained;
}
void bdrv_io_limits_disable(BlockDriverState *bs)
--
1.8.3.1
- [Qemu-block] [PATCH v4 0/8] bdrv_flush_io_queue removal, shared LinuxAioState, Paolo Bonzini, 2016/04/07
- [Qemu-block] [PATCH v4 3/8] block: move restarting of throttled reqs to block/throttle-groups.c, Paolo Bonzini, 2016/04/07
- [Qemu-block] [PATCH v4 4/8] block: extract bdrv_drain_poll/bdrv_co_yield_to_drain from bdrv_drain/bdrv_co_drain, Paolo Bonzini, 2016/04/07
- [Qemu-block] [PATCH v4 1/8] block: Don't disable I/O throttling on sync requests, Paolo Bonzini, 2016/04/07
- [Qemu-block] [PATCH v4 2/8] block: make bdrv_start_throttled_reqs return void,
Paolo Bonzini <=
- [Qemu-block] [PATCH v4 5/8] block: introduce bdrv_no_throttling_begin/end, Paolo Bonzini, 2016/04/07
- [Qemu-block] [PATCH v4 6/8] block: plug whole tree at once, introduce bdrv_io_unplugged_begin/end, Paolo Bonzini, 2016/04/07
- [Qemu-block] [PATCH v4 7/8] linux-aio: make it more type safe, Paolo Bonzini, 2016/04/07
- [Qemu-block] [PATCH v4 8/8] linux-aio: share one LinuxAioState within an AioContext, Paolo Bonzini, 2016/04/07
- Re: [Qemu-block] [PATCH v4 0/8] bdrv_flush_io_queue removal, shared LinuxAioState, Stefan Hajnoczi, 2016/04/19