[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v8 06/15] blockdev: Add blockdev-remove-medium
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v8 06/15] blockdev: Add blockdev-remove-medium |
Date: |
Tue, 27 Oct 2015 14:44:48 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 26.10.2015 um 21:39 hat Max Reitz geschrieben:
> Signed-off-by: Max Reitz <address@hidden>
> + if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_EJECT, errp)) {
> + goto out;
> + }
> +
> + /* This follows the convention established by bdrv_make_anon() */
> + if (bs->device_list.tqe_prev) {
> + QTAILQ_REMOVE(&bdrv_states, bs, device_list);
> + bs->device_list.tqe_prev = NULL;
> + }
> +
> + blk_remove_bs(blk);
Wouldn't it be nicer to move the bdrv_states update into
blk_remove_bs() and blk_insert_bs()? Can be done on top of this series,
though, if you don't need to respin for another reason.
Kevin
- [Qemu-block] [PATCH v8 00/15] blockdev: BlockBackend and media, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 01/15] block: Add blk_remove_bs(), Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 02/15] block: Make bdrv_states public, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 03/15] block: Add functions for inheriting a BBRS, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 04/15] blockdev: Add blockdev-open-tray, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 05/15] blockdev: Add blockdev-close-tray, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 06/15] blockdev: Add blockdev-remove-medium, Max Reitz, 2015/10/26
- Re: [Qemu-block] [PATCH v8 06/15] blockdev: Add blockdev-remove-medium,
Kevin Wolf <=
- [Qemu-block] [PATCH v8 07/15] blockdev: Add blockdev-insert-medium, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 08/15] blockdev: Implement eject with basic operations, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 09/15] blockdev: Implement change with basic operations, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 10/15] block: Inquire tray state before tray-moved events, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 11/15] qmp: Introduce blockdev-change-medium, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 12/15] hmp: Use blockdev-change-medium for change command, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 13/15] blockdev: read-only-mode for blockdev-change-medium, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 14/15] hmp: Add read-only-mode option to change command, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 15/15] iotests: Add test for change-related QMP commands, Max Reitz, 2015/10/26
- Re: [Qemu-block] [PATCH v8 00/15] blockdev: BlockBackend and media, Kevin Wolf, 2015/10/27