[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v8 13/15] blockdev: read-only-mode for blockdev-chan
From: |
Max Reitz |
Subject: |
[Qemu-block] [PATCH v8 13/15] blockdev: read-only-mode for blockdev-change-medium |
Date: |
Mon, 26 Oct 2015 21:39:17 +0100 |
Add an option to qmp_blockdev_change_medium() which allows changing the
read-only status of the block device whose medium is changed.
Some drives do not have a inherently fixed read-only status; for
instance, floppy disks can be set read-only or writable independently of
the drive. Some users may find it useful to be able to therefore change
the read-only status of a block device when changing the medium.
Signed-off-by: Max Reitz <address@hidden>
---
blockdev.c | 22 ++++++++++++++++++++++
hmp.c | 2 +-
qapi/block-core.json | 24 +++++++++++++++++++++++-
qmp-commands.hx | 24 +++++++++++++++++++++++-
qmp.c | 3 ++-
5 files changed, 71 insertions(+), 4 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index e609c97..aa6ea89 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2134,6 +2134,8 @@ void qmp_blockdev_insert_medium(const char *device, const
char *node_name,
void qmp_blockdev_change_medium(const char *device, const char *filename,
bool has_format, const char *format,
+ bool has_read_only,
+ BlockdevChangeReadOnlyMode read_only,
Error **errp)
{
BlockBackend *blk;
@@ -2155,6 +2157,26 @@ void qmp_blockdev_change_medium(const char *device,
const char *filename,
bdrv_flags = blk_get_open_flags_from_root_state(blk);
+ if (!has_read_only) {
+ read_only = BLOCKDEV_CHANGE_READ_ONLY_MODE_RETAIN;
+ }
+
+ switch (read_only) {
+ case BLOCKDEV_CHANGE_READ_ONLY_MODE_RETAIN:
+ break;
+
+ case BLOCKDEV_CHANGE_READ_ONLY_MODE_READ_ONLY:
+ bdrv_flags &= ~BDRV_O_RDWR;
+ break;
+
+ case BLOCKDEV_CHANGE_READ_ONLY_MODE_READ_WRITE:
+ bdrv_flags |= BDRV_O_RDWR;
+ break;
+
+ default:
+ abort();
+ }
+
if (has_format) {
options = qdict_new();
qdict_put(options, "driver", qstring_from_str(format));
diff --git a/hmp.c b/hmp.c
index b91821b..9e6b7e5 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1348,7 +1348,7 @@ void hmp_change(Monitor *mon, const QDict *qdict)
}
qmp_change("vnc", target, !!arg, arg, &err);
} else {
- qmp_blockdev_change_medium(device, target, !!arg, arg, &err);
+ qmp_blockdev_change_medium(device, target, !!arg, arg, false, 0, &err);
if (err &&
error_get_class(err) == ERROR_CLASS_DEVICE_ENCRYPTED) {
error_free(err);
diff --git a/qapi/block-core.json b/qapi/block-core.json
index e9fa649..fa08ba9 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1959,6 +1959,24 @@
##
+# @BlockdevChangeReadOnlyMode:
+#
+# Specifies the new read-only mode of a block device subject to the
+# @blockdev-change-medium command.
+#
+# @retain: Retains the current read-only mode
+#
+# @read-only: Makes the device read-only
+#
+# @read-write: Makes the device writable
+#
+# Since: 2.3
+##
+{ 'enum': 'BlockdevChangeReadOnlyMode',
+ 'data': ['retain', 'read-only', 'read-write'] }
+
+
+##
# @blockdev-change-medium:
#
# Changes the medium inserted into a block device by ejecting the current
medium
@@ -1973,12 +1991,16 @@
# @format: #optional, format to open the new image with (defaults to
# the probed format)
#
+# @read-only-mode: #optional, change the read-only mode of the device;
defaults
+# to 'retain'
+#
# Since: 2.5
##
{ 'command': 'blockdev-change-medium',
'data': { 'device': 'str',
'filename': 'str',
- '*format': 'str' } }
+ '*format': 'str',
+ '*read-only-mode': 'BlockdevChangeReadOnlyMode' } }
##
diff --git a/qmp-commands.hx b/qmp-commands.hx
index d6e4d7e..707e0bd 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -4164,7 +4164,7 @@ EQMP
{
.name = "blockdev-change-medium",
- .args_type = "device:B,filename:F,format:s?",
+ .args_type = "device:B,filename:F,format:s?,read-only-mode:s?",
.mhandler.cmd_new = qmp_marshal_blockdev_change_medium,
},
@@ -4180,6 +4180,8 @@ Arguments:
- "device": device name (json-string)
- "filename": filename of the new image (json-string)
- "format": format of the new image (json-string, optional)
+- "read-only-mode": new read-only mode (json-string, optional)
+ - Possible values: "retain" (default), "read-only", "read-write"
Examples:
@@ -4191,6 +4193,26 @@ Examples:
"format": "raw" } }
<- { "return": {} }
+2. Load a read-only medium into a writable drive
+
+-> { "execute": "blockdev-change-medium",
+ "arguments": { "device": "isa-fd0",
+ "filename": "/srv/images/ro.img",
+ "format": "raw",
+ "read-only-mode": "retain" } }
+
+<- { "error":
+ { "class": "GenericError",
+ "desc": "Could not open '/srv/images/ro.img': Permission denied" } }
+
+-> { "execute": "blockdev-change-medium",
+ "arguments": { "device": "isa-fd0",
+ "filename": "/srv/images/ro.img",
+ "format": "raw",
+ "read-only-mode": "read-only" } }
+
+<- { "return": {} }
+
EQMP
{
diff --git a/qmp.c b/qmp.c
index 4e44f98..ddc63ea 100644
--- a/qmp.c
+++ b/qmp.c
@@ -414,7 +414,8 @@ void qmp_change(const char *device, const char *target,
if (strcmp(device, "vnc") == 0) {
qmp_change_vnc(target, has_arg, arg, errp);
} else {
- qmp_blockdev_change_medium(device, target, has_arg, arg, errp);
+ qmp_blockdev_change_medium(device, target, has_arg, arg, false, 0,
+ errp);
}
}
--
2.6.2
- [Qemu-block] [PATCH v8 04/15] blockdev: Add blockdev-open-tray, (continued)
- [Qemu-block] [PATCH v8 04/15] blockdev: Add blockdev-open-tray, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 05/15] blockdev: Add blockdev-close-tray, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 06/15] blockdev: Add blockdev-remove-medium, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 07/15] blockdev: Add blockdev-insert-medium, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 08/15] blockdev: Implement eject with basic operations, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 09/15] blockdev: Implement change with basic operations, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 10/15] block: Inquire tray state before tray-moved events, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 11/15] qmp: Introduce blockdev-change-medium, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 12/15] hmp: Use blockdev-change-medium for change command, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 13/15] blockdev: read-only-mode for blockdev-change-medium,
Max Reitz <=
- [Qemu-block] [PATCH v8 14/15] hmp: Add read-only-mode option to change command, Max Reitz, 2015/10/26
- [Qemu-block] [PATCH v8 15/15] iotests: Add test for change-related QMP commands, Max Reitz, 2015/10/26
- Re: [Qemu-block] [PATCH v8 00/15] blockdev: BlockBackend and media, Kevin Wolf, 2015/10/27