[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 07/34] block: Move flag inheritance
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 07/34] block: Move flag inheritance to bdrv_open_inherited() |
|
Date: |
Fri, 08 May 2015 17:20:46 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
> Instead of letting every caller of bdrv_open() determine the right flags
> for its child node manually and pass them to the function, pass the
> parent node and the role of the newly opened child (like backing file,
> protocol layer, etc.).
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 74
> ++++++++++++++++++++++++++++++++++++++---------
> block/blkdebug.c | 2 +-
> block/blkverify.c | 4 +--
> block/quorum.c | 4 +--
> block/vmdk.c | 5 ++--
> include/block/block.h | 4 ++-
> include/block/block_int.h | 7 +++++
> 7 files changed, 78 insertions(+), 22 deletions(-)
>
Took me a while to follow the flow of information, but looks correct.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-block] [PATCH 06/34] block: Use QemuOpts in bdrv_open_common(), Kevin Wolf, 2015/05/08
[Qemu-block] [PATCH 07/34] block: Move flag inheritance to bdrv_open_inherited(), Kevin Wolf, 2015/05/08
[Qemu-block] [PATCH 09/34] block: Add BlockDriverState.inherits_from, Kevin Wolf, 2015/05/08
[Qemu-block] [PATCH 10/34] block: Fix reopen flag inheritance, Kevin Wolf, 2015/05/08
[Qemu-block] [PATCH 08/34] block: Add list of children to BlockDriverState, Kevin Wolf, 2015/05/08