|
From: | Max Reitz |
Subject: | Re: [Qemu-block] [PATCH 05/34] block: Use macro for cache option names |
Date: | Mon, 11 May 2015 16:59:57 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 11.05.2015 16:51, Kevin Wolf wrote:
Am 11.05.2015 um 16:40 hat Max Reitz geschrieben:On 08.05.2015 19:21, Kevin Wolf wrote:Signed-off-by: Kevin Wolf <address@hidden> --- blockdev.c | 24 ++++++++++++------------ include/block/block.h | 8 ++++++++ 2 files changed, 20 insertions(+), 12 deletions(-)Any reason for not making it part of the BLOCK_OPT_* macros in block_int.h?Those aren't bdrv_open(), but bdrv_create() options, which should be abundantly clear from the fact that they start in BLOCK instead of BDRV. *cough*
Oh, right, how could I have missed that. *cough cough*
I guess I can move the new options to block_int.h indeed, but when it comes to renaming to make the difference clearer, I think I'd prefer renaming the create options.
Sounds good to me. Also, block.h is a more appropriate place, considering this is not an internal option of the block layer, but something for the outer interface.
Max
[Prev in Thread] | Current Thread | [Next in Thread] |