Re: [PATCH-for-8.0 1/2] target/arm/gdbstub: Restrict aarch64_gdb_get_pauth_reg() to CONFIG_TCG

[Philippe Mathieu-Daudé]

On 22/3/23 16:15, Richard Henderson wrote:
> On 3/22/23 07:29, Philippe Mathieu-Daudé wrote:
> > aarch64_gdb_get_pauth_reg() -- although disabled since commit
> > 5787d17a42 ("target/arm: Don't advertise aarch64-pauth.xml to
> > gdb") is still compiled in. It calls pauth_ptr_mask() which is
> > located in target/arm/tcg/pauth_helper.c, a TCG specific helper.
> >
> > Restrict aarch64_gdb_get_pauth_reg() to TCG to avoid a linking
> > error when TCG is not enabled:
> >
> >    Undefined symbols for architecture arm64:
> >      "_pauth_ptr_mask", referenced from:
> >          _aarch64_gdb_get_pauth_reg in target_arm_gdbstub64.c.o
> >    ld: symbol(s) not found for architecture arm64
> >    clang: error: linker command failed with exit code 1 (use -v to see 
> > invocation)
>
> I guess we should move this function somewhere else, because KVM can 
> certainly use pauth, and we do want to be able to produce nice 
> backtraces with gdb.

I ended inlining it (along with pauth_ptr_mask_internal,
renamed as pauth_param_mask):

20230328133054.6553-3-philmd@linaro.org/">https://lore.kernel.org/qemu-devel/20230328133054.6553-3-philmd@linaro.org/