[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/13] hw/arm/imx25_pdk: Replace drive_get_next() by drive
Re: [PATCH v2 05/13] hw/arm/imx25_pdk: Replace drive_get_next() by drive_get()
Mon, 29 Nov 2021 13:22:13 +0000
On Wed, 17 Nov 2021 at 16:34, Markus Armbruster <firstname.lastname@example.org> wrote:
> drive_get_next() is basically a bad idea. It returns the "next" block
> backend of a certain interface type. "Next" means bus=0,unit=N, where
> subsequent calls count N up from zero, per interface type.
> This lets you define unit numbers implicitly by execution order. If the
> order changes, or new calls appear "in the middle", unit numbers change.
> ABI break. Hard to spot in review.
> Machine "imx25-pdk" connects backends with drive_get_next() in a
> counting loop. Change it to use drive_get() directly. This makes the
> unit numbers explicit in the code.
> Cc: Peter Maydell <email@example.com>
> Cc: Jean-Christophe Dubois <firstname.lastname@example.org>
> Cc: email@example.com
> Signed-off-by: Markus Armbruster <firstname.lastname@example.org>
Reviewed-by: Peter Maydell <email@example.com>