Re: [PATCH v3 4/5] tests/acceptance: update sunxi kernel from armbian to 5.10.16

[Niek Linnenbank]

Hi Philippe, Willian,

Thanks for reviewing!

On Mon, Mar 8, 2021 at 8:50 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:

On 3/5/21 4:04 PM, Willian Rampazzo wrote:
> On Thu, Mar 4, 2021 at 5:45 PM Niek Linnenbank <nieklinnenbank@gmail.com> wrote:
>>
>> The linux kernel 4.20.7 binary for sunxi has been removed from apt.armbian.com:
>>
>>   $ ARMBIAN_ARTIFACTS_CACHED=yes AVOCADO_ALLOW_LARGE_STORAGE=yes avocado --show=app,console run -t machine:orangepi-pc tests/acceptance/boot_linux_console.py
>>   Fetching asset from tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi
>>   ...
>>   (1/6) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi:
>>     CANCEL: Missing asset https://apt.armbian.com/pool/main/l/linux-4.20.7-sunxi/linux-image-dev-sunxi_5.75_armhf.deb (0.55 s)
>>
>> This commit updates the sunxi kernel to 5.10.16 for the acceptance
>> tests of the orangepi-pc and cubieboard machines.
>>
>> Signed-off-by: Niek Linnenbank <nieklinnenbank@gmail.com>
>> ---
>>  tests/acceptance/boot_linux_console.py | 40 +++++++++++++-------------
>>  tests/acceptance/replay_kernel.py      |  8 +++---
>>  2 files changed, 24 insertions(+), 24 deletions(-)
>>
>
> I think some devs will not like it,
Maybe you refer to my previous NACKs regarding similar changes in
integration tests. Niek is the author of the test and the maintainer
of the machine, so if he is OK to stop testing the 4.20.7 kernels
and test the 5.10.16 from now on, I won't object.

For me the 4.20.7 kernel would have been OK if it was still available. With that version removed,

I looked at what is now available on https://apt.armbian.com/pool/main/l/. There are quite a lot of packaged kernels there

and 5.10.16 seemed to me a good balance of running newer kernel code with a version that will hopefully stay around for a while.

 

> but, for me, it is fine as we
> don't have the old kernel available anymore:
>
> Reviewed-by: Willian Rampazzo <willianr@redhat.com>
>

Thanks, will add your reviewed-by tag.

Regards,

Niek

--

Niek Linnenbank