Re: [PATCH v3 5/5] tests/acceptance: drop ARMBIAN_ARTIFACTS_CACHED condition for orangepi-pc, cubieboard tests

[Willian Rampazzo]

On Thu, Mar 4, 2021 at 5:48 PM Niek Linnenbank <nieklinnenbank@gmail.com> wrote:
>
> Previously the ARMBIAN_ARTIFACTS_CACHED pre-condition was added to allow 
> running
> tests that have already existing armbian.com artifacts stored in the local 
> avocado cache,
> but do not have working URLs to download a fresh copy.
>
> At this time of writing the URLs for artifacts on the armbian.com server are 
> updated and working.
> Any future broken URLs will result in a skipped acceptance test, for example:
>
>  (1/5) 
> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi:
>   CANCEL: Missing asset 
> https://apt.armbian.com/pool/main/l/linux-4.20.7-sunxi/linux-image-dev-sunxi_5.75_armhf.deb
>  (0.53 s)
>
> This commits removes the ARMBIAN_ARTIFACTS_CACHED pre-condition such that
> the acceptance tests for the orangepi-pc and cubieboard machines can run.
>
> Signed-off-by: Niek Linnenbank <nieklinnenbank@gmail.com>
> ---
>  tests/acceptance/boot_linux_console.py | 12 ------------
>  tests/acceptance/replay_kernel.py      |  2 --
>  2 files changed, 14 deletions(-)
>

Considering the tests are already canceled when an asset is not
available, this makes a lot of sense, so:

Reviewed-by: Willian Rampazzo <willianr@redhat.com>