[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [kvm-unit-tests PATCH v2 05/16] arm/arm64: ITS: Introspection tests
From: |
Andrew Jones |
Subject: |
Re: [kvm-unit-tests PATCH v2 05/16] arm/arm64: ITS: Introspection tests |
Date: |
Mon, 13 Jan 2020 18:33:00 +0100 |
On Fri, Jan 10, 2020 at 03:54:01PM +0100, Eric Auger wrote:
...
> diff --git a/lib/arm/gic.c b/lib/arm/gic.c
> index 8416dde..f9a6f57 100644
> --- a/lib/arm/gic.c
> +++ b/lib/arm/gic.c
> @@ -6,6 +6,7 @@
> #include <devicetree.h>
> #include <asm/gic.h>
> #include <asm/io.h>
> +#include <asm/gic-v3-its.h>
>
> struct gicv2_data gicv2_data;
> struct gicv3_data gicv3_data;
> @@ -44,12 +45,14 @@ static const struct gic_common_ops gicv3_common_ops = {
> * Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
> */
> static bool
> -gic_get_dt_bases(const char *compatible, void **base1, void **base2)
> +gic_get_dt_bases(const char *compatible, void **base1, void **base2,
> + void **base3)
Here's another place that I would prefer using our 120 chars. No need to
put base3 on a new line.
Thanks,
drew
- [kvm-unit-tests PATCH v2 00/16] arm/arm64: Add ITS tests, Eric Auger, 2020/01/10
- [kvm-unit-tests PATCH v2 01/16] libcflat: Add other size defines, Eric Auger, 2020/01/10
- [kvm-unit-tests PATCH v2 02/16] arm: gic: Provide per-IRQ helper functions, Eric Auger, 2020/01/10
- [kvm-unit-tests PATCH v2 03/16] arm/arm64: gic: Introduce setup_irq() helper, Eric Auger, 2020/01/10
- [kvm-unit-tests PATCH v2 04/16] arm/arm64: gicv3: Add some re-distributor defines, Eric Auger, 2020/01/10
- [kvm-unit-tests PATCH v2 05/16] arm/arm64: ITS: Introspection tests, Eric Auger, 2020/01/10
- [kvm-unit-tests PATCH v2 06/16] arm/arm64: ITS: Test BASER, Eric Auger, 2020/01/10
- [kvm-unit-tests PATCH v2 07/16] arm/arm64: ITS: Set the LPI config and pending tables, Eric Auger, 2020/01/10
- [kvm-unit-tests PATCH v2 08/16] arm/arm64: ITS: Init the command queue, Eric Auger, 2020/01/10
- [kvm-unit-tests PATCH v2 09/16] arm/arm64: ITS: Enable/Disable LPIs at re-distributor level, Eric Auger, 2020/01/10
- [kvm-unit-tests PATCH v2 10/16] arm/arm64: ITS: its_enable_defaults, Eric Auger, 2020/01/10