[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 05/14] target/arm/helper: zcr: Add
From: |
Andrew Jones |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 05/14] target/arm/helper: zcr: Add build bug next to value range assumption |
Date: |
Wed, 26 Jun 2019 15:28:46 +0200 |
User-agent: |
NeoMutt/20180716 |
On Wed, Jun 26, 2019 at 12:01:10PM +0200, Auger Eric wrote:
> Hi Drew,
>
> On 6/21/19 6:34 PM, Andrew Jones wrote:
> > Suggested-by: Dave Martin <address@hidden>
> > Signed-off-by: Andrew Jones <address@hidden>
> > ---
> > target/arm/helper.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/target/arm/helper.c b/target/arm/helper.c
> > index df4276f5f6ca..edba94004e0b 100644
> > --- a/target/arm/helper.c
> > +++ b/target/arm/helper.c
> > @@ -5319,6 +5319,7 @@ static void zcr_write(CPUARMState *env, const
> > ARMCPRegInfo *ri,
> > int new_len;
> >
> > /* Bits other than [3:0] are RAZ/WI. */
> > + QEMU_BUILD_BUG_ON(ARM_MAX_VQ > 16);
> Can you document in the commit message why this check is critical?
Sure. I can copy+paste the email subject into the commit message :-)
drew
>
> Thanks
>
> Eric
> > raw_write(env, ri, value & 0xf);
> >
> > /*
> >
>
- Re: [Qemu-arm] [PATCH v2 03/14] target/arm/monitor: Introduce qmp_query_cpu_model_expansion, (continued)
Re: [Qemu-arm] [PATCH v2 05/14] target/arm/helper: zcr: Add build bug next to value range assumption, Auger Eric, 2019/06/26
Re: [Qemu-arm] [PATCH v2 05/14] target/arm/helper: zcr: Add build bug next to value range assumption, Richard Henderson, 2019/06/26
[Qemu-arm] [PATCH v2 06/14] target/arm: Allow SVE to be disabled via a CPU property, Andrew Jones, 2019/06/21