[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v3 02/10] hw/acpi: Do not create memory hotplug me
From: |
Auger Eric |
Subject: |
Re: [Qemu-arm] [PATCH v3 02/10] hw/acpi: Do not create memory hotplug method when handler is not defined |
Date: |
Thu, 28 Mar 2019 15:14:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
Hi Shameer,
On 3/21/19 11:47 AM, Shameer Kolothum wrote:
> From: Samuel Ortiz <address@hidden>
>
> With Hardware-reduced ACPI, the GED device will manage ACPI
s/Hardware-reduced/hardware-reduced
> hotplug entirely. As a consequence, make the memory specific
> events AML generation optional The code will only be added
> when the method name is not NULL.
>
> Signed-off-by: Samuel Ortiz <address@hidden>
> Signed-off-by: Shameer Kolothum <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Thanks
Eric
> ---
> hw/acpi/memory_hotplug.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
> index 80e25f0..98407e3 100644
> --- a/hw/acpi/memory_hotplug.c
> +++ b/hw/acpi/memory_hotplug.c
> @@ -720,10 +720,12 @@ void build_memory_hotplug_aml(Aml *table, uint32_t
> nr_mem,
> }
> aml_append(table, dev_container);
>
> - method = aml_method(event_handler_method, 0, AML_NOTSERIALIZED);
> - aml_append(method,
> - aml_call0(MEMORY_DEVICES_CONTAINER "." MEMORY_SLOT_SCAN_METHOD));
> - aml_append(table, method);
> + if (event_handler_method) {
> + method = aml_method(event_handler_method, 0, AML_NOTSERIALIZED);
> + aml_append(method,
> + aml_call0(MEMORY_DEVICES_CONTAINER "."
> MEMORY_SLOT_SCAN_METHOD));
> + aml_append(table, method);
> + }
>
> g_free(mhp_res_path);
> }
>
- [Qemu-arm] [PATCH v3 09/10] hw/acpi: Add ACPI Generic Event Device Support, (continued)
- [Qemu-arm] [PATCH v3 09/10] hw/acpi: Add ACPI Generic Event Device Support, Shameer Kolothum, 2019/03/21
- [Qemu-arm] [PATCH v3 10/10] hw/arm/virt: Init GED device and enable memory hotplug, Shameer Kolothum, 2019/03/21
- [Qemu-arm] [PATCH v3 08/10] hw/arm/boot: Expose the PC-DIMM nodes in the DT, Shameer Kolothum, 2019/03/21
- [Qemu-arm] [PATCH v3 05/10] hw/arm/virt: Add ACPI support for device memory cold-plug, Shameer Kolothum, 2019/03/21
- [Qemu-arm] [PATCH v3 02/10] hw/acpi: Do not create memory hotplug method when handler is not defined, Shameer Kolothum, 2019/03/21
- Re: [Qemu-arm] [PATCH v3 02/10] hw/acpi: Do not create memory hotplug method when handler is not defined,
Auger Eric <=
- [Qemu-arm] [PATCH v3 03/10] hw/arm/virt: Add virtual ACPI device, Shameer Kolothum, 2019/03/21
- [Qemu-arm] [PATCH v3 06/10] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT, Shameer Kolothum, 2019/03/21
- [Qemu-arm] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt", Shameer Kolothum, 2019/03/21