[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"
From: |
Shameer Kolothum |
Subject: |
[Qemu-arm] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt" |
Date: |
Thu, 21 Mar 2019 10:47:42 +0000 |
This is to disable/enable populating DT nodes in case
any conflict with acpi tables. The default is "off".
This will be used in subsequent patch where cold plug
device-memory support is added for DT boot.
If DT memory node support is added for cold-plugged device
memory, those memory will be visible to Guest kernel via
UEFI GetMemoryMap() and gets treated as early boot memory.
Hence memory becomes non hot-un-unpluggable even if Guest
is booted in ACPI mode.
Signed-off-by: Shameer Kolothum <address@hidden>
---
hw/arm/virt.c | 23 +++++++++++++++++++++++
include/hw/arm/virt.h | 1 +
2 files changed, 24 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 13db0e9..b602151 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1717,6 +1717,20 @@ static void virt_set_highmem(Object *obj, bool value,
Error **errp)
vms->highmem = value;
}
+static bool virt_get_fdt(Object *obj, Error **errp)
+{
+ VirtMachineState *vms = VIRT_MACHINE(obj);
+
+ return vms->use_fdt;
+}
+
+static void virt_set_fdt(Object *obj, bool value, Error **errp)
+{
+ VirtMachineState *vms = VIRT_MACHINE(obj);
+
+ vms->use_fdt = value;
+}
+
static bool virt_get_its(Object *obj, Error **errp)
{
VirtMachineState *vms = VIRT_MACHINE(obj);
@@ -2005,6 +2019,15 @@ static void virt_instance_init(Object *obj)
object_property_set_description(obj, "gic-version",
"Set GIC version. "
"Valid values are 2, 3 and host", NULL);
+ /* fdt is disabled by default */
+ vms->use_fdt = false;
+ object_property_add_bool(obj, "fdt", virt_get_fdt,
+ virt_set_fdt, NULL);
+ object_property_set_description(obj, "fdt",
+ "Set on/off to enable/disable device tree "
+ "nodes in case any conflict with ACPI"
+ "(eg: device memory node)",
+ NULL);
vms->highmem_ecam = !vmc->no_highmem_ecam;
diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
index c5e4c96..14b2e0a 100644
--- a/include/hw/arm/virt.h
+++ b/include/hw/arm/virt.h
@@ -119,6 +119,7 @@ typedef struct {
bool highmem_ecam;
bool its;
bool virt;
+ bool use_fdt;
int32_t gic_version;
VirtIOMMUType iommu;
struct arm_boot_info bootinfo;
--
2.7.4
- [Qemu-arm] [PATCH v3 08/10] hw/arm/boot: Expose the PC-DIMM nodes in the DT, (continued)
- [Qemu-arm] [PATCH v3 08/10] hw/arm/boot: Expose the PC-DIMM nodes in the DT, Shameer Kolothum, 2019/03/21
- [Qemu-arm] [PATCH v3 05/10] hw/arm/virt: Add ACPI support for device memory cold-plug, Shameer Kolothum, 2019/03/21
- [Qemu-arm] [PATCH v3 02/10] hw/acpi: Do not create memory hotplug method when handler is not defined, Shameer Kolothum, 2019/03/21
- [Qemu-arm] [PATCH v3 03/10] hw/arm/virt: Add virtual ACPI device, Shameer Kolothum, 2019/03/21
- [Qemu-arm] [PATCH v3 06/10] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT, Shameer Kolothum, 2019/03/21
- [Qemu-arm] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt",
Shameer Kolothum <=
- Re: [Qemu-arm] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt", Auger Eric, 2019/03/29
- Re: [Qemu-arm] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt", Shameerali Kolothum Thodi, 2019/03/29
- Re: [Qemu-arm] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt", Auger Eric, 2019/03/29
- Re: [Qemu-arm] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt", Ard Biesheuvel, 2019/03/29
- Re: [Qemu-arm] [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt", Auger Eric, 2019/03/29
- Re: [Qemu-arm] [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt", Shameerali Kolothum Thodi, 2019/03/29
[Qemu-arm] [PATCH v3 04/10] hw/arm/virt: Add memory hotplug framework, Shameer Kolothum, 2019/03/21