[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v6 05/14] target/arm: Reorganize PMCC
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v6 05/14] target/arm: Reorganize PMCCNTR accesses |
Date: |
Mon, 15 Oct 2018 13:47:41 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/15/18 1:30 PM, Aaron Lindsay wrote:
> On Oct 15 13:19, Richard Henderson wrote:
>> On 10/15/18 12:50 PM, Richard Henderson wrote:
>>> Ok, looking at this follow-up makes more sense than the previous patch.
>>> Would
>>> it make sense to squash these two together?
>>
>> Or, rather, split into two different patches: the first splits pmccntr_sync
>> and
>> updates all of the existing uses, and the second which adds the migration
>> hooks.
>
> To make sure I understand, you're suggesting essentially reversing the
> order of patches 4 and 5 (and fixing everything up to be consistent)?
Yes.
r~
[Qemu-arm] [PATCH v6 05/14] target/arm: Reorganize PMCCNTR accesses, Aaron Lindsay, 2018/10/10
Re: [Qemu-arm] [Qemu-devel] [PATCH v6 05/14] target/arm: Reorganize PMCCNTR accesses, Aaron Lindsay, 2018/10/15
[Qemu-arm] [PATCH v6 06/14] target/arm: Filter cycle counter based on PMCCFILTR_EL0, Aaron Lindsay, 2018/10/10
[Qemu-arm] [PATCH v6 09/14] target/arm: Add array for supported PMU events, generate PMCEID[01], Aaron Lindsay, 2018/10/10
[Qemu-arm] [PATCH v6 11/14] target/arm: PMU: Add instruction and cycle events, Aaron Lindsay, 2018/10/10