[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v6 03/14] migration: Add post_save function to VMS
From: |
Juan Quintela |
Subject: |
Re: [Qemu-arm] [PATCH v6 03/14] migration: Add post_save function to VMStateDescription |
Date: |
Wed, 17 Oct 2018 14:05:16 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Richard Henderson <address@hidden> wrote:
> On 10/10/18 1:37 PM, Aaron Lindsay wrote:
>> In some cases it may be helpful to modify state before saving it for
>> migration, and then modify the state back after it has been saved. The
>> existing pre_save function provides half of this functionality. This
>> patch adds a post_save function to provide the second half.
>>
>> Signed-off-by: Aaron Lindsay <address@hidden>
>> ---
>> docs/devel/migration.rst | 9 +++++++--
>> include/migration/vmstate.h | 1 +
>> migration/vmstate.c | 10 +++++++++-
>> 3 files changed, 17 insertions(+), 3 deletions(-)
>
> Hmm, maybe. I believe the common practice is for pre_save to copy state into
> a
> separate member on the side, so that conversion back isn't necessary.
Hi
Originally we have that function. We removed it because we had not
remaining uses for it on tree. I am not againt getting it if you need
it.
Once told that, I think you can add a return value as David saide.
And once there, it ia good thing that you document it if it is called
"before" or "after" the subsections_save. There are arguments for doing
it either way, just document it.
Thanks, Juan.
- [Qemu-arm] [PATCH v6 08/14] target/arm: Implement PMOVSSET, (continued)
- [Qemu-arm] [PATCH v6 08/14] target/arm: Implement PMOVSSET, Aaron Lindsay, 2018/10/10
- [Qemu-arm] [PATCH v6 03/14] migration: Add post_save function to VMStateDescription, Aaron Lindsay, 2018/10/10
- Re: [Qemu-arm] [Qemu-devel] [PATCH v6 03/14] migration: Add post_save function to VMStateDescription, Richard Henderson, 2018/10/15
- Re: [Qemu-arm] [Qemu-devel] [PATCH v6 03/14] migration: Add post_save function to VMStateDescription, Dr. David Alan Gilbert, 2018/10/16
- Re: [Qemu-arm] [Qemu-devel] [PATCH v6 03/14] migration: Add post_save function to VMStateDescription, Aaron Lindsay, 2018/10/16
- Re: [Qemu-arm] [Qemu-devel] [PATCH v6 03/14] migration: Add post_save function to VMStateDescription, Dr. David Alan Gilbert, 2018/10/16
- Re: [Qemu-arm] [Qemu-devel] [PATCH v6 03/14] migration: Add post_save function to VMStateDescription, Aaron Lindsay, 2018/10/16
- Re: [Qemu-arm] [Qemu-devel] [PATCH v6 03/14] migration: Add post_save function to VMStateDescription, Dr. David Alan Gilbert, 2018/10/16
- Re: [Qemu-arm] [PATCH v6 03/14] migration: Add post_save function to VMStateDescription, Juan Quintela, 2018/10/17
- Re: [Qemu-arm] [PATCH v6 03/14] migration: Add post_save function to VMStateDescription,
Juan Quintela <=
[Qemu-arm] [PATCH v6 05/14] target/arm: Reorganize PMCCNTR accesses, Aaron Lindsay, 2018/10/10
Re: [Qemu-arm] [Qemu-devel] [PATCH v6 05/14] target/arm: Reorganize PMCCNTR accesses, Aaron Lindsay, 2018/10/15
[Qemu-arm] [PATCH v6 06/14] target/arm: Filter cycle counter based on PMCCFILTR_EL0, Aaron Lindsay, 2018/10/10
[Qemu-arm] [PATCH v6 09/14] target/arm: Add array for supported PMU events, generate PMCEID[01], Aaron Lindsay, 2018/10/10