[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2 7/9] arm: Track M profile handler mode state in
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH v2 7/9] arm: Track M profile handler mode state in TB flags |
Date: |
Thu, 20 Apr 2017 15:25:46 +0100 |
On 17 April 2017 at 05:20, Philippe Mathieu-Daudé <address@hidden> wrote:
> On 04/10/2017 02:13 PM, Peter Maydell wrote:
>> --- a/target/arm/translate.h
>> +++ b/target/arm/translate.h
>> @@ -31,6 +31,7 @@ typedef struct DisasContext {
>> bool vfp_enabled; /* FP enabled via FPSCR.EN */
>> int vec_len;
>> int vec_stride;
>> + bool handler; /* v7M Handler mode */
>
>
> What about a more descriptive name like 'is_v7m_handler_mode' or
> 'v7m_mode_handler'? It makes your next patch easier to understand:
Seems reasonable; I've made that change (but won't repost the
series as that's the only tweak).
thanks
-- PMM
- [Qemu-arm] [PATCH v2 0/9] arm: Implement M profile exception return properly, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 7/9] arm: Track M profile handler mode state in TB flags, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 2/9] arm: Thumb shift operations should not permit interworking branches, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 5/9] arm: Move condition-failed codepath generation out of if(), Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 9/9] arm: Remove workarounds for old M-profile exception return implementation, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 3/9] arm: Factor out "generate right kind of step exception", Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 4/9] arm: Move gen_set_condexec() and gen_set_pc_im() up in the file, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 1/9] arm: Don't implement BXJ on M-profile CPUs, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 8/9] arm: Implement M profile exception return properly, Peter Maydell, 2017/04/10
- [Qemu-arm] [PATCH v2 6/9] arm: Abstract out "are we singlestepping" test to utility function, Peter Maydell, 2017/04/10
- Re: [Qemu-arm] [Qemu-devel] [PATCH v2 0/9] arm: Implement M profile exception return properly, Richard Henderson, 2017/04/15