qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH 03/11] armv7m: QOMify the armv7m container


From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH 03/11] armv7m: QOMify the armv7m container
Date: Thu, 20 Apr 2017 15:17:42 +0100

On 17 April 2017 at 04:59, Philippe Mathieu-Daudé <address@hidden> wrote:
> On Mon, Feb 20, 2017 at 12:35 PM, Peter Maydell <address@hidden>
> wrote:
>> +static const hwaddr bitband_input_addr[ARMV7M_NUM_BITBANDS] = {
>> +    0x20000000, 0x40000000
>> +};
>
>
> What do you think about adding a
>
> #define ARMV7M_BITBAND_[REGION/IOMEM]_SIZE (1ULL << 25) or 0x2000000
>
> and use it at least with memory_region_init_io() and eventually to get the
> output base addr?

I don't think the size of the bitbanding region and the output base
address are inherently related: it's just a coincidence that the
output-region base address is at input-region-base + output-region-size.

I don't particularly object to a constant for the region size,
but I don't currently have any plans to come back to this particular
bit of code for a while (this patch is already in master).

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]