Re: Font size in Output Window

[Ben Pfaff]

address@hidden (Ben Pfaff) writes:

> John Darrington <address@hidden> writes:
>
>> A number of people have complained about the small font size in
>> the output viewer, and indeed on my default setup  it seems to be
>> approx 8pt whereas the rest of psppire is 10pt.
>>
>> I tracked down the cause of that to the function load_font in 
>> cairo.c - I think that pango_font_description_set_size should
>> be used instead of pango_font_description_set_absolute size.
>> The value being passed in is PANGO_SCALE * 10 (My screen is 96 dpi,
>> so 10 * 72 / 96 explains why I get an apparently 8pt font).  At any
>> rate, dropping the "absolute" fixes that problem for me.
>>
>> However, it seems to me that the we should not override the size
>> passed in by the user. We should set it only if the PangoFontMask's
>> SIZE bit is clear.  That way, for example, a visually impaired user 
>> who has set his default gnome font to 44 will also get his output
>> in that size.
>>
>> That however raises the question: what should be the value of the 
>> variable xr->font_height - so far as I can see, this is used to 
>> determine the dimensions of table cells.   The solution that I can 
>> see, then is to uset the maximum of the three font heights.
>
> All of this sounds fine to me.  I'll try to make these changes
> soon.

I experimented with making the simple change from
pango_font_description_set_absolute_size to
pango_font_description_set_size tonight.  Unfortunately it screws
up headers in printing because allocating spaces for printed
headers requires knowing the actual font size, which isn't known
until the font is actually loaded.  We can certainly fix this,
but I'm inclined to just drop the support for printed headers for
now, since I don't think that they are very attractive.  We can
add them back in later.

I ran out of time trying to do this.  I hope to finish up
tomorrow.
-- 
Ben Pfaff 
http://benpfaff.org