pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: do_summary_box() bugs?


From: John Darrington
Subject: Re: do_summary_box() bugs?
Date: Tue, 16 Feb 2010 07:13:36 +0000
User-agent: Mutt/1.5.18 (2008-05-17)

On Mon, Feb 15, 2010 at 03:27:49PM -0800, Ben Pfaff wrote:
     The "Clang" static analyzer found what looks to me like a bug in
     do_summary_box(), in npar-summary.c.
     
     It reports that "desc" can be a null pointer when it is
     dereferenced in the "for" loop at the end.  Indeed, it looks to
     me as if it can be, as long as "desc" can be null, and the code
     itself thinks that it can be, since it tests whether it is
     nonnull.
     
     On my own, I think I see another problem: the code appears to add
     headings for quartiles, but I do not see any code that would
     insert the quartiles themselves.
     
     Let me know what you think.  I'm happy to file a bug report if
     that's what you want.

Please do - or fix it yourself. Thanks.

J'

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.


Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]