poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] pickles: Add new pickle `unittest.pk`


From: Jose E. Marchesi
Subject: Re: [PATCH 1/2] pickles: Add new pickle `unittest.pk`
Date: Tue, 08 Dec 2020 10:21:05 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

>> > +fun tests_run_exit = (Test[] tests) void:
>> > +  {
>> > +    exit (tests_run (tests) ? 0 : 1);
>> > +  }
>> 
>> Is tests_run_exit really necessary?
>
>
> I think exiting with code `1` is useful. We want to communicate the failure.
> I think this is useful running poke unittests in shell scripts (we don't
> know which testing frameworks users want to use).

Well sure, but writing `exit (tests_run (tests) ? 0 : 1)' is easy enough
isnt it.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]