[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] pickles: Add new pickle `unittest.pk`
From: |
Mohammad-Reza Nabipoor |
Subject: |
Re: [PATCH 1/2] pickles: Add new pickle `unittest.pk` |
Date: |
Tue, 8 Dec 2020 12:42:15 +0330 |
Hi, Jose.
On Tue, Dec 08, 2020 at 09:51:27AM +0100, Jose E. Marchesi wrote:
>
> What do you think about using utest as the canonical name for this?
> i.e. utest.pk, utest_run, utest_run_exit, UTest, UTest_Fn, etc.
>
Good suggestion.
> > +fun tests_run_exit = (Test[] tests) void:
> > + {
> > + exit (tests_run (tests) ? 0 : 1);
> > + }
>
> Is tests_run_exit really necessary?
I think exiting with code `1` is useful. We want to communicate the failure.
I think this is useful running poke unittests in shell scripts (we don't
know which testing frameworks users want to use).
Regards,
Mohammad-Reza