poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Updated Makefile and Configure for libjson-c support


From: Jose E. Marchesi
Subject: Re: [PATCH] Updated Makefile and Configure for libjson-c support
Date: Sat, 28 Mar 2020 18:05:39 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)


Hi K.

Another little comment on your patch:

    Subject: Updated Makefile and Configure

We usually use a summary line in the commit message that has this form:

AREA: description

For patches like this one, that impact the build system, we would use
something like:

build: update src/Makefile.am and configure.ac to integrate json-c

This makes it easier to read the commit messages :)

Then, after the summary line, you are expected to include the ChangeLog
entry.  See existing commits for examples.

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]