Re: [PATCH] Updated Makefile and Configure for libjson-c support

[Jose E. Marchesi]

Hey.

    
     dnl Generate output files
     AC_CONFIG_FILES(Makefile
    -                gl/Makefile
    +                lib/Makefile
                     src/Makefile
                     pickles/Makefile
                     doc/Makefile

Your patch seems to be un-doing Tim's recent patch that renamed lib to
gl.
    
    -pkl-gen.pkc pkl-asm.pkc: $(srcdir)/ras $(srcdir)/pkl-insn.def
    +pkl-gen.pkc pkl-asm.pkc: $(srcdir)/ras

Ditto for a recent patch of mine that added the dependency to the rule
above.

    @@ -107,4 +107,7 @@ BUILT_SOURCES += pvm-vm.h pvm-vm1.c pvm-vm2.c
     pvm-vm.h pvm-vm1.c pvm-vm2.c: pvm.jitter
        $(JITTER) $(srcdir)/pvm.jitter --output $(builddir)
    
    +poke_LDADD += $(pkg-config --cflags json-c)
    +poke_CFLAGS += $(pkg-config --libs json-c)

I don't think that is correct.  The PKG_CHECK_MODULES macro you invoked
in configure.ac will set the following variables if (and only if) the
requested module is found: JSONC_CFLAGS and JSONC_LIBS.

Therefore, you should use these variables instead of calling pkg-config
in src/Makefile.am.  Also, you want to add them to poke_LDADD and
poke_CFLAGS only if the JSONC automake conditional is satisfied,
i.e. something like:

if CFLAGS
  poke_CFLAGS += $(JSONC_CFLAGS)
  ...
endif

You may want to look at the problems above and correct them in
kostasch/mi :)

Thanks!