Re: [Paparazzi-devel] PPM and Lisa/M v2.0

[Felix Ruess]

Fix also backported to v5.8 stable branch

On Thu, Jan 14, 2016 at 11:35 AM, Helge Walle <address@hidden> wrote:

Thanks a lot,
Helge.

14. jan. 2016 11:34 skrev "Gautier Hattenberger" <address@hidden>:

Hi,

Since you confirmed that it works now for you, I'll merge it into master very soon.

Gautier

Le 14/01/2016 11:23, Helge Walle a écrit :

Hi Felix,

I checked out the gen_configure branch, and now used:

<subsystem name="radio_control" type="ppm">
   <configure name="RADIO_CONTROL_PPM_PIN" value="UART1_RX"/>
</subsystem>

in my airframe file, which is how it was before v5.8.

For the record, the board is Lisa/M v2.0, radio is Taranis TX with D8R-XP receiver with CPPM output.

Everything works fine now, and I got radio control and nice values in the PPM message!

I have my own fork with a few sensor driver and subsystem modifications, so it would be interesting to know if the modification of gen_aircraft.ml will be permanent.

Thanks a lot for your help,

Helge.

2016-01-13 21:37 GMT+01:00 Felix Ruess <address@hidden>:

Hi Helge,

proposed fix: https://github.com/paparazzi/paparazzi/pull/1517

Would be great if you could confirm that this fixes it for you.

Cheers, Felix

On Tue, Jan 5, 2016 at 12:21 AM, Felix Ruess <address@hidden> wrote:

Hi Helge,

ugh, that is an annoying side effect that I hadn't considered... sorry.

In the generated var/aircrafts/ACNAME/Makefile.ac you can see that the board makefile is included before the makefile variable is set.

@gautierhattenberger, what do you think about changing the generator to put _all_ configure (makefile variables) at the beginning of a target and not only the ones that are nested directly under firmware or target?

We shouldn't really have any configure options that are used more than once (where you would want to change them between subsystems...

Cheers,

Felix

On Fri, Jan 1, 2016 at 6:15 PM, Helge Walle <address@hidden> wrote:

Hi,

And happy new year to the Paparazzi community!

I have just moved directly from v5.4 to v5.8. Using Lisa/M v2.0 in one of my fixedwings, I had to do some changes to my airframe file.

In v5.4 I had:

<subsystem name="radio_control" type="ppm">
   <configure name="RADIO_CONTROL_PPM_PIN" value="UART1_RX"/>
</subsystem>

Now, RADIO_CONTROL_PPM_PIN has moved to the board makefile, and I needed to move the configure line outside of the subsystem lines. so now I have:

<subsystem name="radio_control" type="ppm"/>

and separately:

<configure name="RADIO_CONTROL_PPM_PIN" value="UART1_RX"/>

Maybe the wiki needs to be updated a little, but I am not sure how to put this correctly.

Thanks,

Helge.

_______________________________________________
Paparazzi-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/paparazzi-devel

_______________________________________________
Paparazzi-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/paparazzi-devel

_______________________________________________
Paparazzi-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/paparazzi-devel

_______________________________________________
Paparazzi-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/paparazzi-devel

_______________________________________________
Paparazzi-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/paparazzi-devel