[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8783] C++ implementation of textscan

From: Philip Nienhuis
Subject: [Octave-patch-tracker] [patch #8783] C++ implementation of textscan
Date: Sun, 01 Nov 2015 12:06:43 +0000
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0 SeaMonkey/2.38

Follow-up Comment #1, patch #8783 (project octave):

As mentioned in the maintainers ML thread, here's a first set of tests
currently implemented in strread.m that are actually meant for textscan(), in
the form of a txt file.
An additional test block is for bit width specifiers.

Perusing the list of strread.m tests I think that maybe 3/4 of all those tests
should be amenable as tests for textscan() as well, after a little rewriting
for different output arg format.

I tried to build textscan by "hg import"-ing it in the stable branch (upcoming
4.0.1) but it didn't apply cleanly.
Which makes me wonder why it is made part of oct-stream.cc at all, rather than
being a separate .oct file. 
If it were in a separate .oct file it would be easier to maintain it; i.e., a
complete rebuild + maybe installation of Octave wouldn't be required then,
just a recompile using mkoctfile in an existing Octave. If required it can
also be absorbed back.

I think textscan() as it stands probably still needs quite a bit of attention
once it works. Things to implement and test are bit width specifiers,
remembering input file position (for text string input as well) and probably
quite a bit of ironing out bugs and little issues.

(file #35356)

Additional Item Attachment:

File name: textscan_tests_patch#8783.txt  Size:2 KB


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]