[Octave-bug-tracker] [bug #61312] Extending isprime() with Miller-Rabin test

[Markus Mützel]

Follow-up Comment #21, bug #61312 (project octave):

A 50,000 fold speed-up for some large numbers! That is quite an improvement to
the existing implementation!

Just a few more nit-picking comments. (I hope you don't mind.)
- Use "##" for comments in .m files that start at the beginning of a line.
- Use "#" preceded by two spaces for comments that trail code in the same
line.
- For the negation operator "!", follow up with a space in both C++ and Octave
code.
- Use a space between function name and opening parenthesis in the actual code
and in tests (unless in an [array]).
- If applicable, add a snippet from the expected error message in `%!error`
tests to make sure the function is failing in the way we expect. E.g. `%!error
<unable to convert input> __isprimelarge__ ({'foo'; 'bar'})`


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61312>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/