|
| From: | Markus Mützel |
| Subject: | [Octave-bug-tracker] [bug #61312] Extending isprime() with Miller-Rabin test |
| Date: | Mon, 18 Oct 2021 11:25:18 -0400 (EDT) |
| User-agent: | Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.81 Safari/537.36 Edg/94.0.992.50 |
Follow-up Comment #11, bug #61312 (project octave):
I agree with Kai. Always good work!
1. Sound reasonable.
2. Looks good to me.
3. Adding the file to `COREFCN_SRC` in `libinterp/corefcn/module.mk` should be
enough. (I believe we try to sort that list in lexical order.)
4. It would be nice if you could weed out the headers and only include those
that are actually needed.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?61312>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
| [Prev in Thread] | Current Thread | [Next in Thread] |