[Octave-bug-tracker] [bug #61129] Performance of factor(). Proposed patch attached.

[Kai Torben Ohlhus]

Follow-up Comment #14, bug #61129 (project octave):

Thanks for reading this great discussion resulting in an enormous improvement
for the factor function! ​🙂

Sorry for the delay, the changes where not trivial, and no ready-to-use
benchmark scripts where attached.  I reviewed and tested the attached patches
and come to similar conclusions as the OP and @mleitner, great work 👍 

(file #52017)

To reproduce the benchmark use

file #52018

and a ready-to-apply version of patch6 file #52016 .  Looking at the numbers
for input 1e15 upwards, patch6 is simply amazing!


@OP, I like you comments for future developers and hope to have preserved them
as good as possible, regarding the Octave code style guidelines
https://wiki.octave.org/Contribute .


@OP: How would you like to be credited or do you prefer anonymity?

@mleitner: Would you like to be credited with the name and email from a past
cset https://hg.savannah.gnu.org/hgweb/octave/rev/845aba35fca7 ?


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61129>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/