[Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file

[Rik]

Update of bug #57353 (project octave):

                Category:                    None => Plotting               
                  Status:               Need Info => Confirmed              
                 Release:                   5.1.0 => dev                    

    _______________________________________________________

Follow-up Comment #5:

Confirmed.  I just tested the MWE on the development tip with a debug version
of Octave and obtained the following backtrace.


#0  0x00007fc47c623ee3 in patch::properties::update_vertex_normals
(this=0x7fc444e1c640, reset=false, force=false)
    at libinterp/corefcn/graphics.cc:10132
#1  0x00007fc47c668f36 in patch::properties::update_normals
(this=0x7fc444e1c640, reset=false, force=false)
    at libinterp/corefcn/graphics.h:9299
#2  0x00007fc47c669d70 in patch::properties::update_facelighting
(this=0x7fc444e1c640)
    at libinterp/corefcn/graphics.h:9384
#3  0x00007fc47c666c03 in patch::properties::set_facelighting
(this=0x7fc444e1c640, val=...)
    at libinterp/corefcn/graphics.h:8958
#4  0x00007fc47c590328 in patch::properties::set (this=0x7fc444e1c640,
pname_arg=..., val=...)
    at libinterp/corefcn/graphics-props.cc:4498
#5  0x00007fc47c64b7a5 in base_graphics_object::set (this=0x7fc444e1c630,
pname=..., pval=...)
    at libinterp/corefcn/graphics.h:2703
#6  0x00007fc47c5109d4 in graphics_object::set_value_or_default
(this=0x7fc4527dee40, pname=..., val=...)
    at libinterp/corefcn/graphics.cc:2754
#7  0x00007fc47c5103e3 in graphics_object::set (this=0x7fc4527dee40, args=...)
at libinterp/corefcn/graphics.cc:2537
#8  0x00007fc47c638140 in Fset (interp=..., args=..., nargout=0) at
libinterp/corefcn/graphics.cc:12855


The code in question in graphics.cc is


while (! octave::math::isnan (f(i,nc)) && nc < max_nc)
  nc++;


It sure looks like the test for "nc < max_nc" should appear before nc gets
used to index the faces "f(i,nc)".

Testing that now.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57353>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/