[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #55908] Closing plots much slower in Octave 5.

From: Mike Miller
Subject: [Octave-bug-tracker] [bug #55908] Closing plots much slower in Octave 5.1.0
Date: Tue, 26 Mar 2019 14:30:00 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.75 Safari/537.36

Follow-up Comment #19, bug #55908 (project octave):

They are exposed symbols in the interface of liboctinterp. Even if they are
private, for example do_delete_children, the public method delete_children
calls do_delete_children, and it's inline, so that method is directly linked
into the user application.

If you want a public method example, then properties::remove_child has a new
signature, which means the old method is no longer in the library.

If you could guarantee that no external code links with any of the classes in
graphics.h, then you could make a case for not needing to bump the library
number. But most are tagged OCTINTERP_API, so they are intentionally public
symbols. With my Debian packaging hat on, I would diff the list of symbols
exported by the library and say this definitely needs a soname bump.

If we want to get better at this, maybe we need to use linker scripts and
tighten down the list of symbols that are actually intentionally exported by
liboctave and liboctinterp. But as it is in Octave 5 right now, Markus' change
is not safe for stable.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]