[Octave-bug-tracker] [bug #44370] Octave compiler flags used at build time are not used by mkoctfile

[Mike Miller]

Follow-up Comment #10, bug #44370 (project octave):

This is awesome, thanks for coming up with that so quickly. It almost works
for me. I've made a few more changes in the attached diff, feel free to merge
it into yours. I think these go with the pattern you are going with.

So this looks really good, HAVE_HDF5 doesn't show up in any public header
files now, except for the ones that explicitly have to do with hdf5, and the
load_hdf5 and save_hdf5 functions are no longer conditional.

I've already updated the communications package to use this new interface and
it at least builds, not yet tested. But this looks like the right direction to
me.

Should we move this to bug #43180 since it directly fixes that one also?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?44370>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/