nmh-workers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: inc and non-compliant long lines redux


From: Michael Richardson
Subject: Re: inc and non-compliant long lines redux
Date: Thu, 10 Nov 2022 13:08:02 +0000

I rebuilt nmh on my new laptop, and then tried to apply Andy's patch.
I have pushed it to:
  https://www.sandelman.ca/tmp/nmh/.git branch: andy-long-line-patch
  (I don't have push permission on savannah that I know of)

It did not apply cleanly on master:

1 out of 3 hunks FAILED -- saving rejects to file mts/smtp/smtp.c.rej
1 out of 3 hunks FAILED -- saving rejects to file sbr/netsec.c.rej
2 out of 2 hunks FAILED -- saving rejects to file uip/inc.c.rej
6 out of 12 hunks FAILED -- saving rejects to file uip/popsbr.c.rej

The inc.c changes look deeper due to much context change, and should be
reviewed to see if I got them right:

And, I was unable to insert:

@@ -515,10 +516,12 @@
                strncpy (response, buffer, sizeof(response));
                netsec_set_snoop(nsc, snoopstate);
                return OK;

            case OK:
+               if (seenhdr != TRUE && strnlen(response,sizeof(response)) == 0)
+                   seenhdr = TRUE;
                (*action) (response);
                break;
        }
 }

as the code is no longer a switch/case statement, and I wasn't even sure I
was in the right place.

Not sure where TRUE/FALSE is supposed to be declared, but that didn't compile.

There may also be trailing whitespace errors.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]