[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] browser: keep selection despite of change in nu

From: Rishabh Dave
Subject: Re: [Nano-devel] [PATCH] browser: keep selection despite of change in number of files in cwd
Date: Sun, 8 May 2016 21:21:45 +0530

Implementation is done and patch works as we want it to. The reason
for valgrind to point at closedir() was that I forgot to open
directory as there spread across two functions.

There is one aspect that I am confused about: why do we want to
replace 'kbinput=KEY_WINCH' with 'sitting_on'? We use KEY_WINCH
elsewhere too (in else-if clause of displaying help), so deleting
first occurrence is impossible. Displaying help actually considers
change in window size unlike refresh (comment says only simulate).

Since I do not know why we need it, I felt probability to write
something nonsense was higher for me. So I asked. :)

Another thing, since browser_select_dirname() does not return any
value, (so)  I preferred to do the 'conspicuous change' there as
'selected' is static and required only a decrement.

Attachment: keep-selection-despite-of-change.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]