[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] botan 1.7.3
From: |
Zbigniew Zagórski |
Subject: |
Re: [Monotone-devel] botan 1.7.3 |
Date: |
Mon, 18 Feb 2008 22:27:36 +0100 |
User-agent: |
Thunderbird 2.0.0.9 (Windows/20071031) |
Markus Schiltknecht wrote:
... in general about updating botan to 1.7.3 in monotone
...
61b03ea355c0cfed3fc62b3c7014b106a1e61119 address@hidden
2008-02-17T21:22:45 net.venge.monotone.botan
[This is actually patch for botan itself. So I'm cross posting to
botan-devel]
There is another problem with the new code. This patch visualizes issue:
--- botan/bit_ops.cpp ebab53284a6ab9a749188fcbe417c8dcc73ac052
+++ botan/bit_ops.cpp 3bb7a0fd68305ca2ff7a071798aa4419f783cf02
@@ -64,10 +64,10 @@ u64bit reverse_bytes(u64bit input)
*************************************************/
u64bit reverse_bytes(u64bit input)
{
- input = ((input & 0xFF00FF00FF00FF00) >> 8) |
- ((input & 0x00FF00FF00FF00FF) << 8);
- input = ((input & 0xFFFF0000FFFF0000) >> 16) |
- ((input & 0x0000FFFF0000FFFF) << 16);
+ input = ((input & 0xFF00FF00FF00FF00ull) >> 8) |
+ ((input & 0x00FF00FF00FF00FFull) << 8);
+ input = ((input & 0xFFFF0000FFFF0000ull) >> 16) |
+ ((input & 0x0000FFFF0000FFFFull) << 16);
return rotate_left(input, 32);
}
g++ 3.4.5 complaints about old code that those big integer constants:
a.cpp:9: error: integer constant is too large for 'long' type
BTW g++ (GCC) 4.0.4 20060507 (prerelease) (Debian 4.0.3-3)) also fails
to compile original code.
--
Zbigniew Zagórski
/ software developer / geek / happy daddy /
- [Monotone-devel] Re: bundled libs, (continued)
- [Monotone-devel] Re: bundled libs, Lapo Luchini, 2008/02/18
- Re: [Monotone-devel] Re: bundled libs, Stephen Leake, 2008/02/18
- Re: [Monotone-devel] Re: bundled libs, Markus Schiltknecht, 2008/02/18
- [Monotone-devel] Re: bundled libs, Lapo Luchini, 2008/02/18
- [Monotone-devel] Re: bundled libs, Lapo Luchini, 2008/02/18
- RE: [Monotone-devel] Re: bundled libs, Kelly F. Hickel, 2008/02/18
- Re: [Monotone-devel] Re: bundled libs, Markus Schiltknecht, 2008/02/18
- RE: [Monotone-devel] Re: bundled libs, Kelly F. Hickel, 2008/02/18
- Re: [Monotone-devel] botan 1.7.3, Zbigniew Zagórski, 2008/02/17