Re: [Monotone-devel] Changes in nvm.basic_io.inventory

[William Uther]

On 24/07/2007, at 1:30 AM, Zack Weinberg wrote:

> On 7/23/07, William Uther <address@hidden> wrote:
> > Hrm.  My last commit changed this slightly.  We now:
> >
> >    a) try to delete them when doing recursive deletes
> >    b) Note that a directory with them is not empty rather than
> > erroring if we're looking to see if a dir is empty.
> >    c) Otherwise we throw an exception.
>
> Oh, that's the patch I was talking about!  I think you're on the right
> track there.  The only thing I see in it to be worried about is that
> LUAEXT(read_directory) now throws special files in with everything
> else, which *could* be a problem downstream.  Did you audit uses of
> that?

Not as much as I should have - that lua extension is in tester.cc,  
right.  That means that it is only available in the test-suite, not  
normal mtn.  We could change it to throw an exception if it hits a  
special file.

Eh - not worth it.  That lua extension is only used once, down the  
bottom of testsuite.lua, when it is looking for all the  
__driver__.lua files.  The only way this could cause a problem is if  
you have a special file named __driver__.lua, and in that case I'm  
willing to call it user error.

Be well,

Will      :-}