[Monotone-devel] Re: [PATCH] monotone ls authors

[Steven E. Harris]

Nathaniel Smith <address@hidden> writes:

> It's completely against the idiom,

What idiom? It's idiomatic in our house style here.

> uglifies the code,

Yes, perhaps.

> and does _not_ improve performance.  (end() is inlined anyway!)

Even if so, you're inlining something that looks like this

,----
| iterator end()
|   {
|   return (iterator(_Mylast));
|   }
`----

(constructing a spurious temporary) on every termination
test. Inlining may save call overhead but says nothing about
eliminating operations.

Maybe it's not worth worrying over a small difference here, but in our
own code base here we would flag the repeated end() check in a code
review and require it to be changed. Apparently idioms are less common
than we assume.

-- 
Steven E. Harris