[Monotone-devel] Re: [PATCH] monotone ls authors

[Steven E. Harris]

Bruce Stephens <address@hidden> writes:

> +  for (vector< revision<cert> >::const_iterator i = certs.begin();
> +       i != certs.end(); ++i)

Why keep checking against an end that doesn't change?

  for (vector< revision<cert> >::const_iterator i = certs.begin(),
                                                end = certs.end();
       i != end; ++i)


> +  for (std::set< cert_value >::const_iterator i = authors.begin();
> +       i != authors.end(); ++i)
+    {
+      cout << *i << endl;
+    }

How about std::copy to std::ostream_iterator?

  #include <algorithm>
  #include <iterator>

  std::copy( authors.begin(), authors.end(),
             std::ostream_iterator<cret_value>( std::cout, "\n" ) );

-- 
Steven E. Harris