Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph

[Volker Grabsch]

Martin Lambers <address@hidden> schrieb:
> > That's a valid point. So I agree that we don't need it for
> > OSG, but let's take libraries like OSG and Qt as exceptions,
> > not as the norm.
> 
> I'm still not convinced, but since adding this to pkgconfig does not
> break the build rule "if you want static OSG, add -DOSG_LIBRARY_STATIC
> yourself", I don't care strongly about it.

One more thought on that:

Wouldn't it make more sense to put the static stuff into an #ifdef ?

    #ifdef OSG_LIBRARY_STATIC
    USE_GRAPHICSWINDOW()
    USE_OSGPLUGIN(<plugin1>)
    USE_OSGPLUGIN(<plugin2>)
    ...
    #endif

That way, your build system can decide whether to compile for static
or dynamic linking (by using "-DOSG_LIBRARY_STATIC" or not). I don't
think that one should hardcode that into an application by defining
OSG_LIBRARY_STATIC within your source files.

This is especially true if you compile with "-DOSG_LIBRARY_STATIC"
anyway.

I mean, isn't the static/dynamic decision a task of your build system
(configure.ac, etc.) rather than a task of your source files?

What do you think about that?


Greets,

    Volker

-- 
Volker Grabsch
---<<(())>>---
Administrator
NotJustHosting GbR