Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph

[Martin Lambers]

On Fri, 22. Jan 2010, 01:11:10 +0100, Volker Grabsch wrote:
> > > That's a valid point. So I agree that we don't need it for
> > > OSG, but let's take libraries like OSG and Qt as exceptions,
> > > not as the norm.
> > 
> > I'm still not convinced, but since adding this to pkgconfig does not
> > break the build rule "if you want static OSG, add -DOSG_LIBRARY_STATIC
> > yourself", I don't care strongly about it.
> 
> One more thought on that:
> 
> Wouldn't it make more sense to put the static stuff into an #ifdef ?
> 
>     #ifdef OSG_LIBRARY_STATIC
>     USE_GRAPHICSWINDOW()
>     USE_OSGPLUGIN(<plugin1>)
>     USE_OSGPLUGIN(<plugin2>)
>     ...
>     #endif
> 

Yes, this is what I had in mind. The configure script can determine
whether to use static or dynamic OSG, and add -DOSG_LIBRARY_STATIC to
CPPFLAGS if necessary. The source only needs the code snippet above to
work with both.

Martin