Re: [GMG-Devel] Tags/Collections for batchaddmedia

[Dan Krol]

Hopefully this weekend. Should I be safe to upgrade to the current HEAD of master and migrate my database? (I make backups between upgrades regardless).

On Wed, Nov 4, 2015 at 8:38 AM, Christopher Allan Webber <address@hidden> wrote:

That would be great.  We might release a 0.8.1 very shortly.  maybe we
can make it in for that?

Of course, that's up to what you have time for!

Dan Krol writes:

> Great, thanks. I'm assuming I'd want to make it based on master rather than
> v0.8.0? It looks like the db schema related to collections has changed.
>
> On Tue, Nov 3, 2015 at 2:40 PM, Christopher Allan Webber <
> address@hidden> wrote:
>
>> Awesome, thanks for the patch!
>>
>> Dan Krol writes:
>>
>> > Okay, I'm guessing that the reason tags weren't added to batchaddmedia is
>> > that submit_media takes a string parameter for tag names rather than the
>> > corresponding tag objects. This means that submit_media would likely be
>> > querying for the same tags over and over again, which is very
>> inefficient.
>> > So, it's maybe worth splitting out a function underneath submit_media
>> that
>> > takes the tag objects, which submit_media calls on? Do you all have a
>> > recommended way to do this, that's in line with your code's
>> organization? I
>> > assume just adding tag_objects and collection_objects parameters would
>> > muddy up submit_media's interface.
>>
>> I think that should be possible.  We could just add another keyword
>> argument to submit_media that takes tag objects.
>>
>> > For my own purposes I can just do it the inefficient way for now, if
>> > there's not a great answer for this. Here's what it looks like at the
>> > moment (forked from v0.8.0 fo rnow), and it seems to work:
>> >
>> https://github.com/orblivion/mediagoblin/compare/853b74cd813b3dea3ac351256b3ce1730664d7f9...batchaddmedia-collection-tag
>>
>> Yay!
>>
>> If you wanted to do the more efficient route, I'd quite happily accept a
>> patch/branch and merge it.
>>