mediagoblin-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GMG-Devel] Tags/Collections for batchaddmedia


From: Dan Krol
Subject: [GMG-Devel] Tags/Collections for batchaddmedia
Date: Sun, 1 Nov 2015 13:02:24 -0800

Hello,

I am working on adding auto-add-to-collection to the addmedia and batchadmedia gmg commands. I'd like it for my own purposes, but I'd like to offer it as a patch as well if you all are interested. As long as I'm messaging about my main question (below), I'm curious what you all think about this, whether it's a good idea and anything I should keep in mind, before I finish and submit it.

But the main thing I was wondering was, how come even tags are unsupported in the batch version, whereas they're supported in the single item version?

http://git.savannah.gnu.org/cgit/mediagoblin.git/tree/mediagoblin/gmg_commands/batchaddmedia.py#n153

tags_string=u"",

Is this just a leftover to-do item? If so, I'd be happy to try to add that in as well, because again I would like it for my own purposes. Or is there some big technical complication here, and I'd just be wasting my efforts?

One thing I can think of is that you'd want to join all the requested tags and query/create them at once instead of repeatedly for each item in the list. And then there's the rollback question in case of error, but that's relevant even in the single item version.

Cheers,

Dan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]