[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Maposmatic-dev] [PATCH 3/4] Adapt feeds url code to Django 1.4

From: David MENTRE
Subject: Re: [Maposmatic-dev] [PATCH 3/4] Adapt feeds url code to Django 1.4
Date: Sat, 21 Apr 2012 14:06:02 +0200


2012/4/19 David MENTRE <address@hidden>:
> I would have preferred to do a bisect to understand which patch broke
> maposmatic on 1.3 but I don't have enough time this evening.

OK, I could try git bisect. According to it:
690ee0c2bdf21d81006885dca64cea7a7d809dd1 is the first bad commit
commit 690ee0c2bdf21d81006885dca64cea7a7d809dd1
Author: Thomas Petazzoni <address@hidden>
Date:   Wed Apr 18 22:08:54 2012 +0200

    Adapt feeds url code to Django 1.4

    Since 1.2, the declaration for the RSS feed url has slightly changed,
    and the old way is no longer available in Django 1.4. So, switch to
    the new way.

    Signed-off-by: Thomas Petazzoni <address@hidden>

$ git bisect log
# bad: [a89c4cfa98ba16115cf17bdf18242badcdd49d4c] Read the GIS
database lag from a local file
# good: [4fc890c8d50a62ecd6c6e55b71edb7a689152613] Catch and log
daemon exceptions
git bisect start 'HEAD' '4fc890c8d50a62ecd6c6e55b71edb7a689152613'
# good: [fa688a561167f8f11f6efbcd5f65f215dcd4251e] Adapt template
loaders to Django 1.4
git bisect good fa688a561167f8f11f6efbcd5f65f215dcd4251e
# bad: [690ee0c2bdf21d81006885dca64cea7a7d809dd1] Adapt feeds url code
to Django 1.4
git bisect bad 690ee0c2bdf21d81006885dca64cea7a7d809dd1

I don't know enough to judge if this way of changing the feed is correct or not.

The patch I proposed previously in this thread is working for me
(Django 1.3). Any way to test it on Django 1.2 and 1.4[1]?

Best regards,

[1] Even if it works, it means we lose the GeoRSS feature, even if I
don't know what is behind it. ;-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]