[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Maposmatic-dev] [PATCH 3/4] Adapt feeds url code to Django 1.4

From: David MENTRE
Subject: Re: [Maposmatic-dev] [PATCH 3/4] Adapt feeds url code to Django 1.4
Date: Thu, 19 Apr 2012 21:29:33 +0200

Hello Thomas and Étienne,

2012/4/19 Thomas Petazzoni <address@hidden>:
>> import django
>> assert django.VERSION[0] == 1 and django.VERSION[1] >= 2
>> if django.VERSION[1] == 2:
>>     from django.contrib.syndication.views import Feed
>> else:
>>     from django.contrib.gis.feeds import Feed
> Well, it's the opposite: the code running with Django 1.2 uses
> django.contrib.gis.feeds while the code I've done for Django 1.4 uses
> django.contrib.syndication.views.

There is something I don't understand. I am using Django 1.3. With
current HEAD, maposmatic breaks with the __init__ error with 3 args

Until now, I had no issue. So your changes for 1.4 have broken
something for 1.3, beyond 1.2 compatibility.

With the attached patch, following suggestions of this thread, it
works on my 1.3 version. But I cannot tell for 1.4 and 1.2. And it
loses GeoRSS of 1.2. And I am not comfortable at all with those module

I would have preferred to do a bisect to understand which patch broke
maposmatic on 1.3 but I don't have enough time this evening.

Best regards,

PS: <rant>Such import issues is for me a very good reason to prefer
statically typed languages to dynamically typed ones.</rant>

Attachment: 0001-Bug-fix-import-Feed-in-a-way-that-works-for-both-Dja.patch
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]