[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Maposmatic-dev] [PATCH ocitysmap] Add "public_building" into street

From: Thomas Petazzoni
Subject: Re: [Maposmatic-dev] [PATCH ocitysmap] Add "public_building" into street index amenities (task 10049)
Date: Thu, 7 Jan 2010 09:08:28 +0100


Le Wed,  6 Jan 2010 18:32:37 +0100,
David MENTRE <address@hidden> a écrit :

> diff --git a/ocitysmap/ b/ocitysmap/
> index 15f079f..4aa642f 100644
> --- a/ocitysmap/
> +++ b/ocitysmap/
> @@ -286,6 +286,7 @@ class OCitySMap:
>              (_(u"Education"), "library", _(u"Library")),
>              (_(u"Public buildings"), "townhall", _(u"Town hall")),
>              (_(u"Public buildings"), "post_office", _(u"Post
> office")),
> +            (_(u"Public buildings"), "public_building", _(u"Public
> buildings")), (_(u"Public buildings"), "police", _(u"Police"))]
>          datasource = dict(self.parser.items('datasource'))

What type of buildings are marked simply public_building ?

In addition, the third item of each tuple is the name that will be
displayed in the index if the name tag of the location is empty.
Therefore, it should not be a plural form. I.e, _(u"Public building")
instead of _(u"Public buildings"). But as "Public building" is
completely useless as an information, I'm wondering whether we should
completely discard amenity=public_building entries when name is empty.

What do you think ?


Thomas Petazzoni               
Promouvoir et défendre le Logiciel Libre
Logiciels Libres à Toulouse    

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]