[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Maposmatic-dev] [PATCH] Bounding box with map - another try

From: Thomas Petazzoni
Subject: Re: [Maposmatic-dev] [PATCH] Bounding box with map - another try
Date: Wed, 9 Sep 2009 09:28:11 +0200

Hello Étienne,

I'm Cc'ing the answer to you since it seems you're not (yet ?)
subscribed to the -dev list.

Le Tue, 8 Sep 2009 21:31:54 +0200,
Étienne Loks <address@hidden> a écrit :

> Here some pieces of code to provide a slippy map for the bounding box.
> This code go further (and is a bit cleaner) than the one provided by
> David :
>  - two way to update : moving the map is changing inputs and changing
> inputs moves the map
>  - separate JS file to manage the slippy map
>  - creation of a Django widget to manage the bounding box field
> (inputs + the map)

Thanks a lot!

There was one issue with the patch that I could fix: there was a
disagreement between your widget/JS code and our form validation code
on the naming of the fields (lon_lower_right instead of
lon_bottom_right). I could fix it, and get some rendering done
properly. So it works nicely at home.

But once on the production server, it fails badly. See

Do you have an idea ?

Another thing: could you create your patch with "git format-patch"
instead of "git diff". This create patches that are easier to apply and
that allow to keep authorship consistent in the Git history. If you
need some help on Git usage, you can join #maposmatic on Freenode.

Thanks again!

Thomas Petazzoni               
Promouvoir et défendre le Logiciel Libre
Logiciels Libres à Toulouse    

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]