Re: [Lynx-dev] ANN: lynx2.8.9dev.16

[Gisle Vanem]

Thomas Dickey wrote:

> hmm - if it's generated (and the page indicates clang-cl is Windows)
> how is it generated?

In my home-made GNU makefile. No other options for Windows/MSVC.

> but it is outside that.  The code reads
>      error = getaddrinfo(host, port, &hints, &res);
>      if (error || !res) {
>         CTRACE((tfp, "HTGetAddrInfo: getaddrinfo(%s, %s): %s\n", host, port,
>                 gai_strerror(error)));
>      } else {
>
> and the free is past the end of the else.  If it's null, that's (according
> to the nearly-30-year-old standard) okay.

My mistake; that code was not active in my build. But a
getaddrinfo() with a free(). Not a freeaddrinfo()?

> > shouldn't this be:
> >    EnterCriticalSection(&critSec_READ);
>
> possibly (it's very old code...)

What about all the '#ifdef WIN_EX' code? Shouldn't it be default
for _WIN32/_WINDOWS? Building w/o it, causes all kinds of
compile errors. Not sure about '#ifdef WIN_GUI'?

--
--gv