Re: [Lynx-dev] ANN: lynx2.8.9dev.16

[Gisle Vanem]

Thomas Dickey wrote:

> The current version of lynx is 2.8.8
>
> It's available at
>         http://lynx.invisible-island.net/
>         ftp://invisible-island.net/lynx/

When using clang-cl to build this version, I got this
error:
  WWW/Library/Implementation/HTFTP.c(3968,40):  error: expected ')'
                      if (sscanf(response_text, "%d %" SCN_off_t, &code, &size)
                                                     ^
  WWW/Library/Implementation/HTFTP.c(3968,17):  note: to match this '('
                      if (sscanf(response_text, "%d %" SCN_off_t, &code, &size)
                                ^

SCN_off_t should be "I64d" in my build, but not sure how
to tweak that into effect (seems <inttypes.h> is not included).
For now, I just put that in my generated lynx_cfg.h.

Also, in HTTCP.c / really_getaddrinfo(), it seems the
  free(res);

should be outside the
  if (error || !res) {

block (otherwise a crash could happen in 'free(res)').
BTW, the code-style and use of tabs makes this difficult
to read.

And in HTTP.c / ws_netread(), the:
  InitializeCriticalSection(&critSec_READ);

shouldn't this be:
  EnterCriticalSection(&critSec_READ);

Several other warnings from clang-cl. Please try it.
It's an awesome compiler.

--
--gv